AutoRelayer: remove forwards #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeHowarth
requested review from
chase-45,
derpy-duck,
a5-pickle,
gator-boi,
kcsongor,
evan-gray and
kev1n-peters
as code owners
derpy-duck
reviewed
Aug 16, 2023
| // and there ends up not being enough funds, | ||
| // then we will revert this call) | ||
| // (Previously needed for reverts, but waiting to remove since this is sensitive code | ||
| // and would need a real audit to redeploy) | ||
| try |
There was a problem hiding this comment.
correct me if I'm wrong, but executeInstruction should never revert right? Can we not remove the failure case of this
There was a problem hiding this comment.
as in, can we just change this into a normal function call rather than an external call
There was a problem hiding this comment.
Yeah I think you're right, but was doing the "only remove dead code" pr first like we discussed.
|
tryDecodeExecuteInstructionError can be removed too probably? (since there will be no errors) |
derpy-duck
reviewed
Aug 16, 2023
sdk/js/scripts/compileAnchorIdls.js
Outdated
| } | ||
| if (!fs.existsSync(TS)) { | ||
| fs.mkdirSync(TS); | ||
| } | ||
|
|
There was a problem hiding this comment.
do we remove this file's changes from this PR
derpy-duck
previously approved these changes
Aug 17, 2023
derpy-duck
force-pushed
the
auto-relayer/rm-forwards
branch
from
31d3df1
to
7b7b44a
Compare
JoeHowarth
force-pushed
the
auto-relayer/rm-forwards
branch
from
2f50b3e
to
7573a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwards are currently broken due to charging the integrator's gas budget for temporary storage slots that can't be refunded properly to the integrator.
In this pr:
The pr will be followed by a pr allowing cheap cross-chain refunds to make up for the lack of forwards. This will be achieved by not verifying the VAA.