Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix spelling issues #4047

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

docs: fix spelling issues #4047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afb88f2
fix query_proxy.md
nnsW3 Jul 31, 2024
c8802a5
fix Messages.sol
nnsW3 Jul 31, 2024
84b1ee1
fix README.md
nnsW3 Jul 31, 2024
b6661d1
fix token_upgrades.md
nnsW3 Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/query_proxy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ The following are the Solana call types. Both require the `chain` parameter plus
- `solAccount`, requires the `account` parameter.
- `solPDA`, requires the `programAddress` parameter.

The Solana account and and program address can be expressed as either a 32 byte hex string starting with "0x" or as a base 58 value.
The Solana account and program address can be expressed as either a 32 byte hex string starting with "0x" or as a base 58 value.

#### Wild Card Contract Addresses

Expand Down
2 changes: 1 addition & 1 deletion ethereum/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ ethereum$ MNEMONIC=<redacted> ./sh/deployTokenBridgeShutdown.sh

#### Generate Flattened Source

To generated the flattened source files to verify the contracts using the explorer UI
To generate the flattened source files to verify the contracts using the explorer UI

```shell
ethereum$ ./sh/flatten.sh
Expand Down
2 changes: 1 addition & 1 deletion ethereum/contracts/Messages.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import "./libraries/external/BytesLib.sol";
contract Messages is Getters {
using BytesLib for bytes;

/// @dev parseAndVerifyVM serves to parse an encodedVM and wholy validate it for consumption
/// @dev parseAndVerifyVM serves to parse an encodedVM and wholly validate it for consumption
function parseAndVerifyVM(bytes calldata encodedVM) public view returns (Structs.VM memory vm, bool valid, string memory reason) {
vm = parseVM(encodedVM);
/// setting checkHash to false as we can trust the hash field in this case given that parseVM computes and then sets the hash field above
Expand Down
2 changes: 1 addition & 1 deletion terra/docs/token_upgrades.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,5 @@ Currently there is no implementation of a token contract migration function that

## Historical note:

In Aug 2022, an attempt to upgrade the the token contracts was made, but failed due to the gas error:
In Aug 2022, an attempt to upgrade the token contracts was made, but failed due to the gas error:
https://finder.terra.money/classic/tx/FE39E9549770F59E2AAA1C6B0B86DDF36A4C56CED0CFB0CA4C9D4CC9FBE1E5BA. A subsequent upgrade changed the code id of *new* wrapped contracts to 767, but did not perform the migration for old contracts. This means that currently (as of Dec 2023), some wrapped tokens are still on the old code id, and some (the ones deployed after Aug 2022) are on the new code. This discrepancy is fine in the current case, because it only affects the rendering of the token name (https://github.com/wormhole-foundation/wormhole/commit/c832b123fcfb017d55086cb4d71241370ed270c6).
Loading