Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidity core contract differential fuzzing #4100

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

djb15
Copy link
Collaborator

@djb15 djb15 commented Aug 27, 2024

The original purpose of this fuzzing suite was to give more confidence around the changes in #3366. This fuzz test suite uses both the currently deployed core contract, and deploys the current local implementation, before performing an arbitrary sequence of calls across both forks.

Given the timeline and consensus around that PR is unclear I've decided to pull these fuzz tests into this PR.

Fuzz tests can be executed with:

echidna fuzz-upgrade/DiffFuzzUpgrades.sol --contract DiffFuzzUpgrades --config fuzz-upgrade/CryticConfig.yaml

Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this test is valuable, should it be run in CI alongside the others?

@djb15
Copy link
Collaborator Author

djb15 commented Aug 27, 2024

If this test is valuable, should it be run in CI alongside the others?

I was concerned about tying CI to an RPC given we're forking mainnet for this fuzz test, and from what I've seen it looks like we hit the endpoint pretty hard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants