Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sim] GUI: Don't show Window menu if it has no contents #7432

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

PeterJohnson
Copy link
Member

@PeterJohnson PeterJohnson requested review from a team as code owners November 24, 2024 07:40
@KangarooKoala
Copy link
Contributor

We should be careful about linking allwpilib PRs to 2025Beta issues, since my understanding is that the policy has been to close 2025Beta issues after a new release that contains the fix, not after main contains the fix (i.e. the PR is merged).

@PeterJohnson
Copy link
Member Author

I think it’s important to link them. We can always reopen the issue.

@PeterJohnson PeterJohnson merged commit b6de7ac into wpilibsuite:main Nov 26, 2024
43 of 44 checks passed
@PeterJohnson PeterJohnson deleted the simgui-window-menu-fix branch November 26, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimGUI Window menu empty
2 participants