Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): 🎨 name added to CoreAvatar component #306

Merged
merged 1 commit into from
Aug 20, 2024
Merged

feat(core): 🎨 name added to CoreAvatar component #306

merged 1 commit into from
Aug 20, 2024

Conversation

techoneel
Copy link
Member

@techoneel techoneel commented Aug 20, 2024 •
edited
Loading

Description

Added name to the core component CoreAvatar for identification and documentation of the core component.

Related Issues

#305

Testing

Checklist

  • I have performed a thorough self-review of my code.
  • I have added or updated relevant tests for my changes.
  • My code follows the project's style guidelines and best practices.
  • I have updated the documentation if necessary.
  • I have added or updated relevant comments in my code.
  • I have resolved any merge conflicts of my branch.

Screenshots (if applicable)

Additional Notes

Reviewers

Maintainer Notes

  • Has this change been tested in a staging environment?
  • Does this change introduce any breaking changes or deprecations?

@techoneel
feat(core): 🎨 core component name added
c028a0f 
core component CoreAvatar name added

Ref #305
@techoneel techoneel added the enhancement New feature or request label Aug 20, 2024
@techoneel techoneel self-assigned this Aug 20, 2024
@techoneel techoneel merged commit ba17767 into development Aug 20, 2024
5 checks passed
anantakumarghosh
anantakumarghosh reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@anantakumarghosh anantakumarghosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check mentioned

package/components/dataDisplay/CoreAvatar.js
@@ -15,7 +15,7 @@ export default function CoreAvatar(props) {

return <NativeAvatar {...props} src={src} />;
}

CoreAvatar.name = "CoreAvatar";
Copy link
Member

@anantakumarghosh anantakumarghosh Aug 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is read-only.
change name to displayName

techoneel added a commit that referenced this pull request Aug 21, 2024
@techoneel
feat(core): ⚡ new utility function and component added
75e700c 
copy to clipboard - new utility function and component added

Ref #306
@techoneel techoneel mentioned this pull request Aug 21, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anantakumarghosh anantakumarghosh anantakumarghosh left review comments

Assignees

@techoneel techoneel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@techoneel @anantakumarghosh