Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(global): ✨ add dimension, update add flavour #124

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

PritamBag
Copy link
Member

Description

Use dimension to calculate height and width in mobile applications, also update add flavour to resolve styles in react native.
Ref: #121

Related Issues

wrappid/core#417

Testing

Checklist

  • I have performed a thorough self-review of my code.
  • I have added or updated relevant tests for my changes.
  • My code follows the project's style guidelines and best practices.
  • I have updated the documentation if necessary.
  • I have added or updated relevant comments in my code.
  • I have resolved any merge conflicts of my branch.

Screenshots (if applicable)

Additional Notes

Reviewers


Maintainer Notes

  • Has this change been tested in a staging environment?
  • Does this change introduce any breaking changes or deprecations?

commented the code that give lint error

Ref: #121
updated lint error

Ref: #121
this are temporary fix for mobile application, this needs to update in future

Ref: #121
diamension is help to calculate height, width in mobile application, Also fix styles in add flavour

Ref: #121
diamension is help to calculate height, width in mobile application, Also fix styles in add flavour

Ref: #121
@PritamBag PritamBag added the enhancement New feature or request label Nov 5, 2024
@PritamBag PritamBag requested a review from techoneel November 5, 2024 12:12
@PritamBag PritamBag self-assigned this Nov 5, 2024
@techoneel techoneel merged commit 22cbe8f into development Nov 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants