Fixed issue with SignInUserSilent() calling a synchronous native meth…

…od in Android rather than an async method.
wrobins · Feb 21, 2024 · 35a5c55 · 35a5c55
1 parent 5599f07
commit 35a5c55
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "cordova-plugin-msal",
-    "version": "4.1.0",
+    "version": "4.1.1",
     "description": "A Cordova plugin providing a wrapper for Microsoft's MSAL library for Android and iOS.",
     "cordova": {
       "id": "cordova-plugin-msal",

diff --git a/plugin.xml b/plugin.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
         xmlns:android="http://schemas.android.com/apk/res/android"
-        id="cordova-plugin-msal" version="4.1.0">
+        id="cordova-plugin-msal" version="4.1.1">
     <name>Cordova MSAL Plugin</name>
     <description>A Cordova plugin providing a wrapper for Microsoft's MSAL library for Android and iOS.</description>
     <author>Walter Robins</author>

diff --git a/src/android/MsalPlugin.java b/src/android/MsalPlugin.java
@@ -326,6 +326,7 @@ public void run() {
                                 AcquireTokenSilentParameters params = new AcquireTokenSilentParameters.Builder()
                                         .withScopes(Arrays.asList(MsalPlugin.this.scopes))
                                         .fromAuthority(authority)
+                                        .forAccount(MsalPlugin.this.appSingleClient.getCurrentAccount().getCurrentAccount())
                                         .withCallback(new SilentAuthenticationCallback() {
                                             @Override
                                             public void onSuccess(IAuthenticationResult authenticationResult) {
@@ -338,7 +339,7 @@ public void onError(MsalException exception) {
                                             }
                                         })
                                         .build();
-                                MsalPlugin.this.appSingleClient.acquireTokenSilent(params);
+                                MsalPlugin.this.appSingleClient.acquireTokenSilentAsync(params);
                             }
                         } catch (InterruptedException e) {
                             MsalPlugin.this.callbackContext.error(e.getMessage());
@@ -381,7 +382,7 @@ public void onError(MsalException exception) {
                                         }
                                     })
                                     .build();
-                            MsalPlugin.this.appMultipleClient.acquireTokenSilent(params);
+                            MsalPlugin.this.appMultipleClient.acquireTokenSilentAsync(params);
                         } catch (InterruptedException e) {
                             MsalPlugin.this.callbackContext.error(e.getMessage());
                         } catch (MsalException e) {