New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting pre and post listeners for get user with ID and cursor pagination for identity claims. #595

Closed

BojithaPiyathilake wants to merge 3 commits into wso2-extensions:master from BojithaPiyathilake:adjustbranchgovernance

Contributor

BojithaPiyathilake commented May 26, 2022 •

edited

Loading

Proposed changes in this pull request

The purpose of this PR is for;

handlePreGetUserListWithID and handlePostGetUserListWithID to be functional and call the necessary listeners when requesting a cursor paginated request instead of an index paginated request.
To get cursor paginated results when identity claims are stored in a default identity database.
To get cursor paginated results when identity claims are stored in a user store.

Related Issues

Cursor-based Pagination for SCIM Resources wso2/product-is#13294

Dependant PRs

Cursor based pagination for SCIM resources phase 1. wso2/carbon-kernel#3281
PR builder fails as the new enum from carbon-kernel has not been merged yet.

Test environment

Java versions

JDK 1.8
Open JDK 11.0.15

OS

Ubuntu 20.04

IS:

WSO2IS-5.12.0-alpha14,

User stores:

JDBC
- DB2 - 11.5.7.0
- Oracle - 19.3.0-ee
- MSSQL - Microsoft SQL Server 2019 - 15.0.4223.1 (X64)
- MySQL - Ver 8.0.29
- Postgres - PostgreSQL 14.3
LDAP


          Adjusting pre and post listeners for get user with ID when using curs…

9affd23

…or pagination

BojithaPiyathilake mentioned this pull request

Cursor based pagination for SCIM resources phase 1. wso2/carbon-kernel#3281

Closed

BojithaPiyathilake commented

View reviewed changes

...e/src/main/java/org/wso2/carbon/identity/governance/listener/IdentityStoreEventListener.java Show resolved Hide resolved

BojithaPiyathilake commented

View reviewed changes

...overnance/src/main/java/org/wso2/carbon/identity/governance/store/JDBCIdentityDataStore.java Outdated Show resolved Hide resolved

BojithaPiyathilake commented

View reviewed changes

...overnance/src/main/java/org/wso2/carbon/identity/governance/store/JDBCIdentityDataStore.java Show resolved Hide resolved

BojithaPiyathilake commented

View reviewed changes

...overnance/src/main/java/org/wso2/carbon/identity/governance/store/JDBCIdentityDataStore.java Show resolved Hide resolved

BojithaPiyathilake commented

View reviewed changes

...overnance/src/main/java/org/wso2/carbon/identity/governance/store/JDBCIdentityDataStore.java Outdated Show resolved Hide resolved

BojithaPiyathilake commented

View reviewed changes

...overnance/src/main/java/org/wso2/carbon/identity/governance/store/JDBCIdentityDataStore.java Outdated Show resolved Hide resolved

BojithaPiyathilake added 2 commits

June 17, 2022 15:31


          Adding cursor pagination for Oracle, DB2, MSSQL when identity claims …

168b97a

…are stored in a separate identity store


          Changing the type of direction attribute to enum

710b296

somindatommy requested a review from AnuradhaSK

August 9, 2022 04:29

Contributor

AnuradhaSK commented Aug 29, 2022

Closing this PR for now as it's been open for more than 14 days. Will reopen and merge soon

AnuradhaSK closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet