Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add useClientIdAsSubClaimForAppTokens and omitUsernameInIntrospectionRespForAppTokens configs to app" #2573

Merged

Conversation

mpmadhavig
Copy link
Contributor

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 37.72%. Comparing base (b498f13) to head (5605916).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...2/carbon/identity/oauth/OAuthAdminServiceImpl.java 0.00% 2 Missing ⚠️
...arbon/identity/oauth2/token/AccessTokenIssuer.java 0.00% 1 Missing ⚠️
...tity/oauth2/validators/TokenValidationHandler.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2573      +/-   ##
============================================
- Coverage     37.78%   37.72%   -0.07%     
+ Complexity     5321     5293      -28     
============================================
  Files           584      584              
  Lines         44529    44395     -134     
  Branches       6538     6525      -13     
============================================
- Hits          16827    16746      -81     
+ Misses        25351    25307      -44     
+ Partials       2351     2342       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11007684163

@mpmadhavig
Copy link
Contributor Author

Merging the PR without the Integration tests as there are integration test that uses this removing module.

@mpmadhavig mpmadhavig merged commit 3e4c265 into wso2-extensions:master Sep 24, 2024
3 of 4 checks passed
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11007684163
Status: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants