Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clean Up] Clean OIDC session code v1 #2621

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

Thumimku
Copy link
Contributor

@Thumimku Thumimku commented Nov 8, 2024

Proposed changes in this pull request

  1. Log is a static final variable, so it should be "LOG" not "log".
  2. Clean some un used code.
  3. Checking for debug enabled is redundent, but improve performance if the logging message contains computations. But if there is no computations, no concatinations then checking debug enabled affect the performance. Hence I selectively remove debug enabled checks if the message is simple.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 55.14%. Comparing base (69881de) to head (6303c3c).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
...n/backchannellogout/DefaultLogoutTokenBuilder.java 0.00% 16 Missing ⚠️
...y/oidc/session/handler/OIDCLogoutEventHandler.java 0.00% 16 Missing ⚠️
...session/backchannellogout/LogoutRequestSender.java 0.00% 12 Missing ⚠️
...c/session/backchannellogout/ClaimProviderImpl.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2621      +/-   ##
============================================
- Coverage     55.24%   55.14%   -0.10%     
- Complexity     8260     8300      +40     
============================================
  Files           632      632              
  Lines         47943    48644     +701     
  Branches       7867     7980     +113     
============================================
+ Hits          26484    26825     +341     
- Misses        17630    17950     +320     
- Partials       3829     3869      +40     
Flag Coverage Δ
unit 38.68% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11766728732

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11766728732
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11766728732

@Thumimku Thumimku merged commit f4d499f into wso2-extensions:master Nov 11, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants