Skip to content

Commit

Permalink
Fix formatting issues
Browse files Browse the repository at this point in the history
  • Loading branch information
hwupathum committed Jun 22, 2023
1 parent 7123cb3 commit 5e4d363
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ public boolean addRelyingPartyServiceProvider(SAMLSSOServiceProviderDTO serviceP
log.error(message);
return false;
}
return IdentitySAMLSSOServiceComponentHolder.getInstance().getSAMLSSOServiceProviderManager().addServiceProvider(serviceProviderDO, tenantId);
return IdentitySAMLSSOServiceComponentHolder.getInstance().getSAMLSSOServiceProviderManager()
.addServiceProvider(serviceProviderDO, tenantId);
} catch (IdentityException e) {
String message = "Error obtaining a registry for adding a new service provider";
throw new IdentityException(message, e);
Expand Down Expand Up @@ -410,8 +411,8 @@ private SAMLSSOServiceProviderDTO createSAMLSSOServiceProviderDTO(SAMLSSOService
public SAMLSSOServiceProviderInfoDTO getServiceProviders() throws IdentityException {
SAMLSSOServiceProviderDTO[] serviceProviders = null;
try {
SAMLSSOServiceProviderDO[] providersSet = IdentitySAMLSSOServiceComponentHolder.getInstance().getSAMLSSOServiceProviderManager()
.getServiceProviders(tenantId);
SAMLSSOServiceProviderDO[] providersSet = IdentitySAMLSSOServiceComponentHolder.getInstance()
.getSAMLSSOServiceProviderManager().getServiceProviders(tenantId);
serviceProviders = new SAMLSSOServiceProviderDTO[providersSet.length];

for (int i = 0; i < providersSet.length; i++) {
Expand Down Expand Up @@ -499,7 +500,8 @@ public SAMLSSOServiceProviderInfoDTO getServiceProviders() throws IdentityExcept
*/
public boolean removeServiceProvider(String issuer) throws IdentityException {
try {
return IdentitySAMLSSOServiceComponentHolder.getInstance().getSAMLSSOServiceProviderManager().removeServiceProvider(issuer, tenantId);
return IdentitySAMLSSOServiceComponentHolder.getInstance()
.getSAMLSSOServiceProviderManager().removeServiceProvider(issuer, tenantId);
} catch (IdentityException e) {
throw new IdentityException("Error removing a Service Provider with issuer: " + issuer, e);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ public static IdentitySAMLSSOServiceComponentHolder getInstance() {
* @param samlSSOServiceProviderManager SAMLSSOServiceProviderManager.
*/
public void setSAMLSSOServiceProviderManager(SAMLSSOServiceProviderManager samlSSOServiceProviderManager) {

this.samlSSOServiceProviderManager = samlSSOServiceProviderManager;
}

Expand All @@ -53,6 +54,7 @@ public void setSAMLSSOServiceProviderManager(SAMLSSOServiceProviderManager samlS
* @return SAMLSSOServiceProviderManager.
*/
public SAMLSSOServiceProviderManager getSAMLSSOServiceProviderManager() {

return samlSSOServiceProviderManager;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1900,8 +1900,7 @@ public static boolean validateACS(String tenantDomain, String issuerName, String
privilegedCarbonContext.setTenantDomain(tenantDomain);

SAMLSSOServiceProviderDO spDO = IdentitySAMLSSOServiceComponentHolder.getInstance()
.getSAMLSSOServiceProviderManager().getServiceProvider(issuerName,
tenantId);
.getSAMLSSOServiceProviderManager().getServiceProvider(issuerName, tenantId);
if (StringUtils.isBlank(requestedACSUrl) || !spDO.getAssertionConsumerUrlList().contains
(requestedACSUrl)) {
String msg = "ALERT: Invalid Assertion Consumer URL value '" + requestedACSUrl + "' in the " +
Expand Down

0 comments on commit 5e4d363

Please sign in to comment.