Add doSignResponse property to session during IDP Initiated SSO Flow #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/5583687669
ashendes
previously approved these changes
Jul 26, 2023
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/5687488783
ashendes
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When populating the SAMLSSOServiceProviderDO before adding it to session data, we have missed setting the
isDoSignResponseproperty from the authnReqDTO during the IDP initiated SSO authentication flow. Therefore during logout flow, the default value - false is set for this property when loaded from session data, and therefore the response will not be signed.This PR will set the DoSignResponse to SAMLSSOServiceProviderDO during SSO Auth request processing flow so that this property will be loaded correctly during logout.
This PR introduces a new config to disable signing the logout response after IDP initiated SSO logins, to preserve backward compatibility. This config will be checked before setting the above parameter.
By default, the SAML logout response for SP initiated SSO and IDP initiated SSO login flows will be signed if the
Enable Response Signingproperty is enabled in the Service Provider. But if a customer requires the previous behaviour where the SAML logout response during IDP initiated SSO flow is not signed, the following config can be added to the deployment.toml.Related Issue: wso2/product-is#16207
Related PR: Bump framework after merging wso2/carbon-identity-framework#4803