Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protocol config handler #412

Merged
merged 20 commits into from
Feb 16, 2024
Merged

Add protocol config handler #412

merged 20 commits into from
Feb 16, 2024

Conversation

sahandilshan
Copy link
Contributor

Proposed changes in this pull request

  • Add a protocol config handler to SAMLSSO to call admin services directly from the framework level

With this PR, we will expose the SAMLSSO services from a protocol handler to directly call SAMLAdmin Services from the framework level without publishing audit logs

When should this PR be merged

@sahandilshan
Add protocol config handler
40f9217 
Add a protocol config handler to SAMLSSO to call admin services directly from the framework level
@sahandilshan
Bump framework version
b8c0e11
@sahandilshan
Fix formatting issues
ab10c00
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7040946332

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7040946332
Status: failure

wso2-jenkins-bot added a commit that referenced this pull request Dec 1, 2023
@wso2-jenkins-bot
[WSO2 Release] [Jenkins #412] [Release 5.11.29] prepare release v5.11.29
d2d006d
wso2-jenkins-bot added a commit that referenced this pull request Dec 1, 2023
@wso2-jenkins-bot
[WSO2 Release] [Jenkins #412] [Release 5.11.29] prepare for next deve…
def78d9 
…lopment iteration
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7720965012

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7720965012
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7721111293

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7721111293
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7721111293

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7721111293
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7721111293

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7721111293
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7721111293

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7721111293
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7721111293

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7721111293
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7721111293

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7882233044

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7882233044
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7882233044

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7882233044
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7882233044

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7882233044
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7882233044

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7882233044
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7882233044

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7882233044
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7882233044

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7882233044
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7882233044

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7882233044
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7882233044

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7882233044
Status: failure

@VivekVinushanth
Copy link
Contributor

Locally the build is passing. We need to bump the version and will trigger the PR builder for that and confirm.

@sahandilshan
Copy link
Contributor Author

LGTM. We can go ahead and merge this PR. We have to make sure that version bump PR's integration tests are passing. If not we should revert these changes

@VivekVinushanth
Copy link
Contributor

VivekVinushanth commented Feb 16, 2024 •
edited
Loading

LGTM. We can go ahead and merge this PR. We have to make sure that version bump PR's integration tests are passing. If not we should revert these changes

approving based on this.

@VivekVinushanth VivekVinushanth merged commit efa8470 into wso2-extensions:master Feb 16, 2024
3 checks passed
VivekVinushanth added a commit that referenced this pull request Feb 16, 2024
@VivekVinushanth
Revert "Add protocol config handler (#412)"
5a568ce 
This reverts commit efa8470.
@VivekVinushanth VivekVinushanth mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VivekVinushanth VivekVinushanth VivekVinushanth approved these changes

@piraveena piraveena Awaiting requested review from piraveena

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sahandilshan @jenkins-is-staging @VivekVinushanth