Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keystore and truststore extension to PKCS #415

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Update keystore and truststore extension to PKCS #415

merged 1 commit into from
Jan 20, 2024

Conversation

Thisara-Welmilla
Copy link
Contributor

Issue:

Change the keystore and the truststore file type from JKS to PKCS12.

@Thisara-Welmilla Thisara-Welmilla mentioned this pull request Jan 18, 2024
Open
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7593041893

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7593041893
Status: failure

@Thisara-Welmilla Thisara-Welmilla force-pushed the change-keystore-extensions branch 2 times, most recently from 247f91e to d8fa9e5 Compare January 20, 2024 09:08
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7593440450

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7593440450
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7593537998

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7593537998
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7593850412

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7593850412
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jan 20, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7593850412

@Thisara-Welmilla Thisara-Welmilla merged commit 16c854b into wso2-extensions:master Jan 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMHP DMHP DMHP approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@madurangasiriwardena madurangasiriwardena madurangasiriwardena left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thisara-Welmilla @jenkins-is-staging @madurangasiriwardena @DMHP