Fix mutli-valued claims not separating in the SAML federation flow #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...n/java/org/wso2/carbon/identity/sso/saml/builders/assertion/DefaultSAMLAssertionBuilder.java
Outdated
Show resolved
Hide resolved
mpmadhavig
reviewed
Mar 18, 2024
Comment on lines
480
to
481
| /* reference ApplicationAuthenticationService service to guarantee that this component will wait until | ||
| authentication framework is started */ |
There was a problem hiding this comment.
Suggested change
| /* reference ApplicationAuthenticationService service to guarantee that this component will wait until | |
| authentication framework is started */ | |
| /* Reference ApplicationAuthenticationService service to guarantee that this component will wait until | |
| authentication framework is started. */ |
mpmadhavig
reviewed
Mar 18, 2024
...rc/main/java/org/wso2/carbon/identity/sso/saml/internal/IdentitySAMLSSOServiceComponent.java
Outdated
Show resolved
Hide resolved
mpmadhavig
approved these changes
Mar 18, 2024
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8322165705
| * store's attribute separator. Therefore, to ensure uniformity, the multi-attribute separator from | ||
| * the primary user store is utilized for separating multivalued attributes when MultiAttributeSeparator | ||
| * is not available in the claims. | ||
| */ |
There was a problem hiding this comment.
It is ideal to use block comment (/* */) in these places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SAML outbound authenticator, the concatenation of multivalued attributes relies on the attribute separator configured in the primary user store. To ensures consistency, multi-attribute separator from the primary user store is employed to separate multivalued attributes here when the MultiAttributeSeparator is absent in the claims.
Important:
This fix is a workaround and the issue for a proper fix is tracked here
Related Issues