Merge pull request #522 from hwupathum/patch-400

Return 404 response when changing a non-existing role
wso2-extensions · Jan 22, 2024 · b01e383 · b01e383
2 parents 0fcb440 + ff89a31
commit b01e383
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...m2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManagerV2.java b/...m2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManagerV2.java
@@ -714,7 +714,7 @@ private void doUpdateRoleName(RoleV2 oldRole, RoleV2 newRole)
  }
  }
 
- private String getCurrentRoleName(String roleId, String tenantDomain) throws CharonException, BadRequestException {
+ private String getCurrentRoleName(String roleId, String tenantDomain) throws CharonException, NotFoundException {
 
  String currentRoleName;
  try {
@@ -724,7 +724,7 @@ private String getCurrentRoleName(String roleId, String tenantDomain) throws Cha
  }
  } catch (IdentityRoleManagementException e) {
  if ((ROLE_NOT_FOUND.getCode()).equals(e.getErrorCode())) {
- throw new BadRequestException(e.getMessage());
+ throw new NotFoundException(e.getMessage());
  }
  throw new CharonException(String.format("Error occurred while getting the role name by " +
  "the role id: %s", roleId), e);