Fix invalidValue code and update to generic error message for group I…

…D requirement
wso2-extensions · Jul 4, 2024 · b10c883 · b10c883
1 parent 04d7b00
commit b10c883
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/...cim2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManager.java b/...cim2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManager.java
@@ -777,9 +777,8 @@ private void prepareAddedRemovedGroupLists(Set<String> addedGroupsIds, Set<Strin
         String value = groupObject.get(SCIMConstants.CommonSchemaConstants.VALUE);
 
         if (StringUtils.isBlank(value)) {
-            throw new BadRequestException(
-                    "Updating groups of the role by display name is not supported. Update using group id instead.",
-                    ResponseCodeConstants.INVALID_SYNTAX);
+            throw new BadRequestException("Group id is required to update group of the role.",
+                    ResponseCodeConstants.INVALID_VALUE);
         }
 
         switch (groupOperation.getOperation()) {

diff --git a/...m2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManagerV2.java b/...m2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManagerV2.java
@@ -1219,9 +1219,8 @@ private void prepareInitialGroupLists(Set<String> givenAddedGroupsIds, Set<Strin
         String value = groupObject.get(SCIMConstants.CommonSchemaConstants.VALUE);
 
         if (StringUtils.isBlank(value)) {
-            throw new BadRequestException(
-                    "Updating groups of the role by display name is not supported. Update using group id instead.",
-                    ResponseCodeConstants.INVALID_SYNTAX);
+            throw new BadRequestException("Group id is required to update group of the role.",
+                    ResponseCodeConstants.INVALID_VALUE);
         }
 
         switch (groupOperation.getOperation()) {