Skip to content

Commit

Permalink
Addressed comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ashanthamara committed May 13, 2024
1 parent d7f04fb commit e6f0491
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -534,8 +534,8 @@ public void deleteUser(String userId) throws NotFoundException, CharonException,
} else if (userStoreDomainFromSP != null &&
!(userStoreDomainFromSP
.equalsIgnoreCase(coreUser.getUserStoreDomain()))) {
throw new CharonException("User :" + maskIfRequired(coreUser.getUsername()) + "is not belong to user " +
"store " + userStoreDomainFromSP + ". Hence user updating fail.");
throw new CharonException("User : " + maskIfRequired(coreUser.getUsername()) + " is not belong to " +
"user store " + userStoreDomainFromSP + ". Hence user updating fail.");
} else {
// We assume (since id is unique per user) only one user exists for a given id.
userName = coreUser.getUsername();
Expand Down Expand Up @@ -1019,7 +1019,7 @@ public User updateUser(User user, Map<String, Boolean> requiredAttributes) throw
User oldUser = this.getUser(user.getId(), ResourceManagerUtil.getAllAttributeURIs(schema));
if (userStoreDomainFromSP != null && !userStoreDomainFromSP
.equalsIgnoreCase(IdentityUtil.extractDomainFromName(oldUser.getUserName()))) {
throw new CharonException("User :" + maskIfRequired(oldUser.getUserName()) + "is not belong to " +
throw new CharonException("User : " + maskIfRequired(oldUser.getUserName()) + " is not belong to " +
"user store " + userStoreDomainFromSP + ". Hence user updating fail.");
}
if (getUserStoreDomainFromSP() != null &&
Expand Down Expand Up @@ -1526,7 +1526,7 @@ private String resolveDomainName(String domainName, ExpressionNode node) throws
domainName = resolveDomainNameInAttributeValue(domainName, node);
} catch (BadRequestException e) {
String errorMessage = String.format("Domain parameter: %s in request does not match with the domain " +
"name in the attribute value: %s ", domainName, maskIfRequired(node.getValue()));
"name in the attribute value: %s", domainName, maskIfRequired(node.getValue()));
throw new CharonException(errorMessage, e);
}
// Get domain name according to Filter Enhancements properties as in identity.xml
Expand Down

0 comments on commit e6f0491

Please sign in to comment.