Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor based pagination for SCIM resources phase 1 #417

Closed
wants to merge 2 commits into from
Closed

Cursor based pagination for SCIM resources phase 1 #417

wants to merge 2 commits into from

Conversation

BojithaPiyathilake
Copy link
Contributor

@BojithaPiyathilake BojithaPiyathilake commented May 3, 2022 •
edited
Loading

Purpose

The purpose of this PR is to get the initial phase of cursor pagination for SCIM resource listings working with the Identity Server in JDBC and LDAP user stores.

Goals

  • User passes in the cursor or startIndex and the limit and the IS provides a (cursor or offset) paginated result.
  • Ability to travel forwards and backwards across pages using cursor pagination.
  • Cursor paginated functionality for both JDBC and LDAP user stores.

Related Issues

Related PRs

Dependent PRs

Test environment

  1. Java versions
  • JDK 1.8
  • Open JDK 11.0.15
  1. OS
  • Ubuntu 20.04
  1. IS:
  • WSO2IS-5.12.0-alpha14,
  1. User stores:
  • JDBC
    • DB2 - 11.5.7.0
    • Oracle - 19.3.0-ee
    • MSSQL - Microsoft SQL Server 2019 - 15.0.4223.1 (X64)
    • MySQL - Ver 8.0.29
    • Postgres - PostgreSQL 14.3
  • LDAP

@CLAassistant
Copy link

CLAassistant commented May 3, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

This was referenced May 3, 2022
Open
Closed
@BojithaPiyathilake
Cursor pagination for SCIM resources.
44d0b63 
Cursor pagination changes phase 1

formatting adjustments before PR

Few changes after the code review

Changes suggested in the code review

Changed strings into constants

Changing the response type from a List to UsersGetResponse type object

Changes to support pagination with POST/.Search. Group filtering changes. Changes to SingleAttribute and MultiAttribute filtering to properly create the UsersGetResponse.

Removing commented code

Made changes for the ServiceProviderConfigEndpoint to show that cursor pagination is supported

Wording updates to the ServiceProviderConfigEndpoint changes

Making changes so that cursor pagination uses PRIMARY domain when a domain is not specified

Removing unused parameters

Adjusting the test cases broken due to changes made and introductig new test cases for the new flows

Adding punctuation to the comments
@BojithaPiyathilake
Fixed test issue
5dfe690
@AnuradhaSK
Copy link
Contributor

Closing this PR for now as it's been open for more than 14 days. Will reopen and merge soon

@AnuradhaSK AnuradhaSK closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BojithaPiyathilake @CLAassistant @AnuradhaSK