Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle forbidden responses when updating roles with a patch request #476

Merged
merged 5 commits into from
Jul 13, 2023
Merged

Handle forbidden responses when updating roles with a patch request #476

merged 5 commits into from
Jul 13, 2023

Conversation

Yasasr1
Copy link
Contributor

@Yasasr1 Yasasr1 commented Jul 6, 2023 •
edited
Loading

Purpose

Only the tenant owner is allowed to remove users from the Administrator role. Framework throws an error if the authorized user doesn't have the permissions when making the request. Previously a 500 error was thrown in this scenario. However 403 should be returned instead of 500.

Related PR

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5516130546

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5516130546
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5516805502

@jenkins-is-staging
Copy link

PR builder [7.x.x] started
Link: https://github.com/wso2/product-is/actions/runs/5517923014

@jenkins-is-staging
Copy link

PR builder [7.x.x] completed
Link: https://github.com/wso2/product-is/actions/runs/5517923014
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jul 11, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/5517923014

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5516805502
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5538381096

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5538381096
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jul 13, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/5538381096

@Yasasr1 Yasasr1 merged commit a585099 into wso2-extensions:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@dewniMW dewniMW dewniMW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yasasr1 @jenkins-is-staging @dewniMW