Improve the performance by having equal operator instead of LIKE operator when counting total users #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator when counting total users
DMHP
reviewed
Aug 24, 2023
| .getSecondaryUserStoreManager(domainName); | ||
| } | ||
| try { | ||
| if (secondaryUserStoreManager instanceof JDBCUserStoreManager) { |
There was a problem hiding this comment.
What will happen if the userstore manager is not an instance of JDBCUserStoreManager? It will return the totalUsers as 0
There was a problem hiding this comment.
No, this will return the page size and if the limit for the page size is not defined, then the max number of users returned in the response. That is simply the number of users in the response at that time.
Resolve conflicts resolve conflicts
Kanapriya
force-pushed
the
fix_performance_issue
branch
from
2b129bb
to
f31df18
Compare
DMHP
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : wso2/product-is#16324
Carbon Kernel version needs to be updated in this PR, before merging this PR, this PR needs to be merged - wso2/carbon-kernel#3642