Block role creation for sub organizations. #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnuradhaSK
previously approved these changes
Oct 19, 2023
|
PR builder started |
thanujalk
previously approved these changes
Oct 19, 2023
|
PR builder completed |
PasinduYeshan
dismissed stale reviews from thanujalk and AnuradhaSK
via
489e6dd
AnuradhaSK
approved these changes
Oct 19, 2023
|
PR builder started |
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6577699679
sadilchamishka
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To provide bulk user import feature for sub organizations the
scim2/Bulkendpoint should be accessible for sub-organizations, which allows various operations, including role creation.However, the initial intent was to avoid supporting the /scim2/Roles endpoint in the o/ path for sub-organizations. Instead, the organization roles should be used to manage permissions.
Proposed Changes:
This PR introduces a restriction that prevents role creation from sub-organizations.