Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add org perspective SCIM2 servlet mappings #494

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Add org perspective SCIM2 servlet mappings #494

merged 1 commit into from
Oct 26, 2023

Conversation

sadilchamishka
Copy link
Contributor

@sadilchamishka sadilchamishka commented Oct 26, 2023 •
edited
Loading

$subject

The organization perspective APIs were referenced by the existing organization allowed APIs

Screenshot 2023-10-26 at 06 32 44

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6648059048

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6648060302

@sadilchamishka sadilchamishka changed the title Add org perspective user & role manageent servelet mappings Add org perspective SCIM2 servlet mappings Oct 26, 2023
@AnuradhaSK
Copy link
Contributor

This change will cause the API paths in a way that

scim2/o/Users etc
But we want o/scim2/Users
Isn’t it ?

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6648060302
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 26, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6648060302

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6648059048
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 26, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6648059048

@sadilchamishka
Copy link
Contributor Author

sadilchamishka commented Oct 26, 2023 •
edited
Loading

This change will cause the API paths in a way that

scim2/o/Users etc But we want o/scim2/Users Isn’t it ?

Sample request

But we want o/scim2/Users Isn’t it ? yes. The input for the context rewrite valve /t/carbon.super/o/scim2/Users
The above mentioned URL path is processed in this manner at the valve level.
contextToForward = scim2
dispatchLocation = Users
dispatchLocation = /o + dispatchLocation

Screenshot 2023-10-26 at 09 11 50

@sadilchamishka sadilchamishka merged commit c2ad167 into wso2-extensions:master Oct 26, 2023
3 checks passed
@sadilchamishka sadilchamishka mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnuradhaSK AnuradhaSK AnuradhaSK approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadilchamishka @jenkins-is-staging @AnuradhaSK