Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for the count parameter #541

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Add validation for the count parameter #541

merged 4 commits into from
Mar 26, 2024

Conversation

mpmadhavig
Copy link
Contributor

@mpmadhavig mpmadhavig commented Mar 22, 2024 •
edited
Loading

Describe

This PR will fix the default maximum number of records per request(100) is not being honored by SCIM GET Users API. As the fix, added a validation for the count parameter which check whether the count is exceeding the configured default maximum number of records per request parameter. If yes, then sets the count value to 100.

When this PR need to be merged

  1. Merge and Release Add SCIM2 user endpoint pagination enabled config wso2/carbon-identity-framework#5599 PR.
  2. Bump framework version with the released version.
  3. Run the PR builder.

Related issues:

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8384249122

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8384249122
Status: failure

@mpmadhavig mpmadhavig mentioned this pull request Mar 22, 2024
Open
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8387249874

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8387249874
Status: failure

@mpmadhavig mpmadhavig force-pushed the validate-count-parameter-value branch 2 times, most recently from 23a276e to 5a2419a Compare March 25, 2024 13:12
ashensw
ashensw previously approved these changes Mar 25, 2024
View reviewed changes
@mpmadhavig mpmadhavig force-pushed the validate-count-parameter-value branch from d9da9df to 586af8d Compare March 25, 2024 14:43
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8421998222

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8421998222
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8421998222

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8421998222
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Mar 25, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8421998222

@mpmadhavig mpmadhavig merged commit ba53d35 into wso2-extensions:master Mar 26, 2024
3 checks passed
@sandushi sandushi mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashensw ashensw ashensw approved these changes

@AfraHussaindeen AfraHussaindeen AfraHussaindeen approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpmadhavig @jenkins-is-staging @ashensw @AfraHussaindeen