Fix multi-attribute user filter with count provided. #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thisara-Welmilla
force-pushed
the
fix-users-filter
branch
from
9e45f9d to
7fa1068
Compare
Thisara-Welmilla
force-pushed
the
fix-users-filter
branch
from
7fa1068 to
987416e
Compare
|
PR builder started |
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9974859708
ashanthamara
approved these changes
Jul 21, 2024
Thisara-Welmilla
merged commit 272d92c
into
wso2-extensions:master
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: wso2/product-is#20496
When count(limit) > 0, use the
getMultiAttributeFilteredUsersWithMaxLimitwith limit is provided as the given count given.Adiition to that this contain the fix to honor the provided count value in the SCIM2 request for multi attribute filtering flow.
Ported the logic(used in the single attribute filtering flow) with minor modification: https://github.com/wso2-extensions/identity-inbound-provisioning-scim2/blob/master/components/org.wso2.carbon.identity.scim2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMUserManager.java#L1885-L1914