Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: SCIM error handling for group display name (fixes #20344) #558

Closed

Conversation

BimsaraBodaragama
Copy link
Contributor

Purpose

Fix SCIM error handling to provide appropriate messages when a group display name is used instead of a group ID.

Goals

To ensure compliance with RFC 7644 and provide clear, actionable error messages to users when an invalid request is made with a group display name.

Approach

  • Implemented error response with scimType set to invalidSyntax for requests using a group display name instead of a group ID.
  • Provided a clear and concise error message in the detail field.
  • Handled the fix for both V1 and V2 roles.
  • Ensured the error response adhered to the SCIM specification.

Issue

Resolves #20334

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ BimsaraBodaragama
❌ Bimsara Bodaragama


Bimsara Bodaragama seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non descriptive error message for SCIM Roles v2 patch operation
2 participants