Fix: SCIM error message for invalid request values in V1 and V2 Roles Remove-Add-Replace operations (fixes #20334) #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Remove-Add-Replace operations (fixes #20334)
AnuradhaSK
reviewed
Jul 3, 2024
...y.scim2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManager.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Jul 3, 2024
...y.scim2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManager.java
Outdated
Show resolved
Hide resolved
…rors for SCIM error handling in V2 Roles operations
|
PR builder started |
AnuradhaSK
reviewed
Jul 5, 2024
| @Mock | ||
| private RoleManagementService roleManagementService; | ||
| @Mock | ||
| private SCIMRoleManagerV2 scimRoleManagerV2; |
There was a problem hiding this comment.
we should not mock the class which the method we are testing
|
PR builder completed |
jenkins-is-staging
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9803713898
AnuradhaSK
reviewed
Jul 5, 2024
|
|
||
| import static org.mockito.Mockito.when; | ||
| import static org.mockito.MockitoAnnotations.initMocks; | ||
| import static org.testng.AssertJUnit.assertEquals; |
There was a problem hiding this comment.
Suggested change
| import static org.testng.AssertJUnit.assertEquals; | |
| import static org.testng.Assert; |
Let's import org.testng.Assert and use its assertEquals
There was a problem hiding this comment.
Fixed by e97c090
AnuradhaSK
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix SCIM error handling to provide appropriate messages when a group display name is used instead of a group ID.
Goals
To ensure compliance with RFC 7644 and provide clear, actionable error messages to users when an invalid request is made with a group display name.
Approach
scimTypeset toinvalidSyntaxfor requests using a group display name instead of a group ID.detailfield.Issue
Resolves #20334