Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve organization user invitation and user sharing #238

Conversation

ShanChathusanda93
Copy link
Contributor

@ShanChathusanda93 ShanChathusanda93 commented Sep 10, 2023

Purpose

  • $subject
  • Added the doPreSetUserClaimValuesWithID to restrict the user claim update for shared users.
  • Made the followings configurable.
    • Expiry time of the invitations.
    • Default user store domain for users in the parent organization.
    • Default user redirection URL for invitation acceptance.
  • Improve doPreDeleteUserWithID listener.

@ShanChathusanda93 ShanChathusanda93 force-pushed the org-user-invite-improve-branch branch 4 times, most recently from fa40715 to 61345a6 Compare September 11, 2023 05:49
@ShanChathusanda93 ShanChathusanda93 force-pushed the org-user-invite-improve-branch branch from 61345a6 to 2e4f78d Compare September 12, 2023 12:14
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6163182942

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6163182942
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6163182942

@ShanChathusanda93 ShanChathusanda93 merged commit bd2be37 into wso2-extensions:main Sep 13, 2023
1 check passed
@@ -54,6 +57,22 @@ public boolean doPreDeleteUserWithID(String userID, UserStoreManager userStoreMa
}
}

@Override
public boolean doPreSetUserClaimValuesWithID(String userID, Map<String, String> claims, String profileName,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if single claim update method is invoked?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be addressed from a different PR.

dewniMW pushed a commit to dewniMW/identity-organization-management-1 that referenced this pull request Sep 20, 2023
dewniMW pushed a commit to dewniMW/identity-organization-management-1 that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants