Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit discoverable property to the shared apps #390

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

asha15
Copy link
Contributor

@asha15 asha15 commented Aug 29, 2024

Purpose

$subject

Related issue: wso2/product-is#21118

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.53%. Comparing base (d766096) to head (4c67494).
Report is 316 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #390   +/-   ##
=========================================
  Coverage     41.53%   41.53%           
  Complexity      218      218           
=========================================
  Files            30       30           
  Lines          1678     1678           
  Branches        187      187           
=========================================
  Hits            697      697           
  Misses          938      938           
  Partials         43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

VivekVinushanth
VivekVinushanth previously approved these changes Sep 2, 2024
@AnuradhaSK
Copy link
Contributor

@asha15 please add a unit test as well

SujanSanjula96
SujanSanjula96 previously approved these changes Sep 17, 2024
@asha15
Copy link
Contributor Author

asha15 commented Sep 18, 2024

Merging PR due to the urgency. Will create a separate PR to include unit test

@asha15 asha15 merged commit 6733639 into wso2-extensions:main Sep 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants