Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC support for APK #2092

Merged
merged 52 commits into from
Apr 26, 2024
Merged

Add gRPC support for APK #2092

merged 52 commits into from
Apr 26, 2024

Conversation

DDH13
Copy link
Contributor

@DDH13 DDH13 commented Mar 6, 2024

Purpose

Add gRPC support for APK in CR level. Changes were mainly in the adapter, enforcer, and common-controller

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2024

CLA assistant check
All committers have signed the CLA.

@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Mar 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.11%. Comparing base (a0e6f15) to head (3246eeb).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2092      +/-   ##
==========================================
- Coverage   27.93%   27.11%   -0.83%     
==========================================
  Files         124      124              
  Lines       14597    15040     +443     
  Branches     2681     2681              
==========================================
  Hits         4078     4078              
- Misses      10388    10829     +441     
- Partials      131      133       +2     
Flag Coverage Δ
adapter 26.27% <ø> (-1.36%) ⬇️
common-controller 4.07% <ø> (ø)
config-deployer-service 25.99% <ø> (ø)
idp-domain-service 80.21% <ø> (ø)
router ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 6, 2024
@Krishanx92 Krishanx92 added the trigger-action When this includes apk actions getting trigger for pr label Mar 11, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 11, 2024
@Krishanx92 Krishanx92 added the trigger-action When this includes apk actions getting trigger for pr label Mar 11, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 11, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Mar 11, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 11, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Mar 11, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 14, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi added the trigger-action When this includes apk actions getting trigger for pr label Mar 16, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 18, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Mar 19, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 19, 2024
@CrowleyRajapakse CrowleyRajapakse added the trigger-action When this includes apk actions getting trigger for pr label Mar 19, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 20, 2024
@O-sura O-sura added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Mar 20, 2024
@CrowleyRajapakse CrowleyRajapakse added the trigger-action When this includes apk actions getting trigger for pr label Mar 20, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 20, 2024
@O-sura O-sura added the trigger-action When this includes apk actions getting trigger for pr label Mar 21, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 26, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Apr 15, 2024
@O-sura O-sura added the trigger-action When this includes apk actions getting trigger for pr label Apr 15, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi changed the base branch from feature/grpc to main April 16, 2024 04:05
@AmaliMatharaarachchi AmaliMatharaarachchi changed the base branch from main to feature/grpc April 16, 2024 04:06
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Apr 16, 2024
generalize testcase a bit more

generalize testcase a bit more

generalize testcase a bit more

generalize testcase a bit more

generalize testcase a bit more

generalize testcase a bit more
adapter/internal/operator/synchronizer/grpc_api.go Outdated Show resolved Hide resolved
test/integration/integration/tests/grpc-api.go Outdated Show resolved Hide resolved
@@ -80,16 +80,15 @@ type APISpec struct {
Sandbox []EnvConfig `json:"sandbox"`

// APIType denotes the type of the API.
// Possible values could be REST, GraphQL, Async
// Possible values could be REST, GraphQL, Async, GRPC etc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to go for alpha3 version. because alpha2 is already released

@O-sura O-sura added the trigger-action When this includes apk actions getting trigger for pr label Apr 26, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Apr 26, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi marked this pull request as ready for review April 26, 2024 09:06
@AmaliMatharaarachchi AmaliMatharaarachchi merged commit 2ea0b3a into wso2:feature/grpc Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants