Merge pull request #12325 from hisanhunais/wrong-string-operation

Use Equals Method for String Comparison
wso2 · Mar 22, 2024 · 11e4c78 · 11e4c78
2 parents 7c02d37 + 3c97711
commit 11e4c78
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/.../org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/ApiMgtDAO.java b/.../org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/ApiMgtDAO.java
@@ -9517,7 +9517,7 @@ public void addKeyManagerConfiguration(KeyManagerConfigurationDTO keyManagerConf
  preparedStatement.setString(10, keyManagerConfigurationDTO.getExternalReferenceId());
  preparedStatement.executeUpdate();
  KeyManagerPermissionConfigurationDTO permissionDTO = keyManagerConfigurationDTO.getPermissions();
- if (permissionDTO != null && permissionDTO.getPermissionType() != KeyManagerAccessPublic) {
+ if (permissionDTO != null && !KeyManagerAccessPublic.equals(permissionDTO.getPermissionType())) {
  try (PreparedStatement addPermissionStatement = conn
  .prepareStatement(SQLConstants.KeyManagerPermissionsSqlConstants
  .ADD_KEY_MANAGER_PERMISSION_SQL)) {
@@ -9598,7 +9598,7 @@ public void updateKeyManagerConfiguration(KeyManagerConfigurationDTO keyManagerC
  deletePermissionsStatement.executeUpdate();
  }
  KeyManagerPermissionConfigurationDTO permissionDTO = keyManagerConfigurationDTO.getPermissions();
- if (permissionDTO != null && permissionDTO.getPermissionType() != KeyManagerAccessPublic) {
+ if (permissionDTO != null && !KeyManagerAccessPublic.equals(permissionDTO.getPermissionType())) {
  try (PreparedStatement addPermissionStatement = conn.prepareStatement(SQLConstants
  .KeyManagerPermissionsSqlConstants.ADD_KEY_MANAGER_PERMISSION_SQL)) {
  for (String role : permissionDTO.getRoles()) {