Fix errors when hostname verification is set as "DefaultAndLocalhost" #12042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To fix the errors thrown while starting the APIM server even if a SAN entry matches the server hostname when hostname verification is set as "DefaultAndLocalhost".
Goal
Fixes: wso2/api-manager#1876
and also fixes issues from: wso2/api-manager#1698
Approach
When DefaultAndLocalhost hostname verifier is enabled, all hostnames that match the below list should pass hostname verification regardless of what is on the server’s certificate.
"::1", "127.0.0.1", "localhost", "localhost.localdomain"
Apart from that above should support default hostname verification as well. So DefaultAndLocalhost verification is Default hostname verification + a relaxation on localhost hostnames.
To fix the above issues we should improve the verify method to validate the hostname against the certs available in the keystore.