Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Basic authentication scope validation faulty #12090

Conversation

thisaltennakoon
Copy link
Contributor

@thisaltennakoon thisaltennakoon commented Jul 18, 2023

@thisaltennakoon thisaltennakoon changed the title Initial commit Fix Basic authentication scope validation faulty Jul 18, 2023
@thisaltennakoon thisaltennakoon marked this pull request as ready for review December 18, 2023 03:48
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9fd3ec1) 37.60% compared to head (4cfe1d0) 42.01%.
Report is 24 commits behind head on master.

❗ Current head 4cfe1d0 differs from pull request most recent head 6385030. Consider uploading reports for the commit 6385030 to get more accurate results

Files Patch % Lines
...a/org/wso2/carbon/apimgt/impl/APIProviderImpl.java 78.94% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12090      +/-   ##
============================================
+ Coverage     37.60%   42.01%   +4.41%     
- Complexity     2547     3196     +649     
============================================
  Files          1812     1813       +1     
  Lines        133643   133680      +37     
  Branches      19316    19325       +9     
============================================
+ Hits          50258    56168    +5910     
+ Misses        76839    70774    -6065     
- Partials       6546     6738     +192     
Flag Coverage Δ
integration_tests 35.22% <90.00%> (+5.63%) ⬆️
unit_tests 20.78% <5.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,25 @@
package org.wso2.carbon.apimgt.impl.notifier.events;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing licence headers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 4cfe1d0

@thisaltennakoon thisaltennakoon force-pushed the Fix-Basic-authentication-scope-validation-faulty branch from f18c0f2 to 4cfe1d0 Compare February 1, 2024 09:07
@npamudika npamudika merged commit bfa05a7 into wso2:master Feb 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API validation getting failed in the basic authentication when updating local scopes
2 participants