-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gateway JWKS Endpoint #12091
Merged
Merged
Add Gateway JWKS Endpoint #12091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashera96
force-pushed
the
gateway-jwks-support
branch
from
July 19, 2023 16:06
ed8c84c
to
a8fe0c5
Compare
ashera96
force-pushed
the
gateway-jwks-support
branch
from
July 21, 2023 06:26
a8fe0c5
to
e18548b
Compare
chamilaadhi
requested changes
Jul 24, 2023
....apimgt.common.gateway/src/main/java/org/wso2/carbon/apimgt/common/gateway/util/JWTUtil.java
Outdated
Show resolved
Hide resolved
...rbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/token/DefaultApiKeyGenerator.java
Outdated
Show resolved
Hide resolved
...on.apimgt.keymgt/src/main/java/org/wso2/carbon/apimgt/keymgt/token/AbstractJWTGenerator.java
Outdated
Show resolved
Hide resolved
...on.apimgt.keymgt/src/main/java/org/wso2/carbon/apimgt/keymgt/token/AbstractJWTGenerator.java
Outdated
Show resolved
Hide resolved
...rbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/token/DefaultApiKeyGenerator.java
Outdated
Show resolved
Hide resolved
...apimgt.gateway/src/main/java/org/wso2/carbon/apimgt/gateway/handlers/common/JwksHandler.java
Show resolved
Hide resolved
tgtshanika
previously approved these changes
Jul 24, 2023
chamilaadhi
reviewed
Jul 25, 2023
...va/org/wso2/carbon/apimgt/common/gateway/jwtgenerator/AbstractAPIMgtGatewayJWTGenerator.java
Outdated
Show resolved
Hide resolved
chamilaadhi
previously approved these changes
Jul 25, 2023
chamilaadhi
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR introduces a JWKS endpoint to the Gateway. Also, a kid claim is added to the backend JWT header via a deployment.toml configuration. If the said config is set to true, backend JWT will include the kid claim. By default the config is set to
true
.Use the following config under
deployment.toml
to toggle the kid claim addition to the backend JWT.JWKS endpoint is exposed via the following URLs:
Super Tenant
: https://<host>:8243/jwksTenant
: https://<host>:8243/t/<tenant domain>/jwks