Resource level filter logging feature added #12106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od and resourcePath properties.
…el and resource level.
… non revision apis only.
…ResoureLevelFilterLogging
…e resource log level
…out resourcePath.
(cherry picked from commit 626eeb6)
(cherry picked from commit db93dd8)
(cherry picked from commit 1f8e1db)
(cherry picked from commit b8cb215)
formatted logging related sql scripts
This was referenced Jul 31, 2023
chamilaadhi
reviewed
Nov 15, 2023
| @@ -494,6 +494,7 @@ public enum ExceptionCodes implements ErrorHandler { | |||
| LOGGING_API_NOT_FOUND(901400, "Requested Resource Not Found", 404, "Request API Not Found for context: %s"), | |||
| LOGGING_API_INCORRECT_LOG_LEVEL(901401, "Bad Request", 400, "Log level should be either OFF, BASIC, STANDARD or FULL"), | |||
| LOGGING_API_MISSING_DATA(901402, "Missing data", 400, "API context or log level is missing"), | |||
| LOGGING_API_RESOURCE_NOT_FOUND(901403, "Requested Resource Not Found", 400, "Requested API Resource Not Found"), | |||
chamilaadhi
reviewed
Nov 15, 2023
| resourcePath = apiLoggerObject.getString("resourcePath"); | ||
| } | ||
| Map<String, String> properties = new HashMap<>(); | ||
| properties.put("context", apiLoggerObject.getString("context")); |
There was a problem hiding this comment.
Use constants and refer. There are many places referring to string like context, resourcePath, etc
chamilaadhi
reviewed
Nov 15, 2023
| import org.apache.synapse.core.axis2.Axis2MessageContext; | ||
| import org.wso2.carbon.apimgt.gateway.APIMgtGatewayConstants; | ||
| import org.wso2.carbon.apimgt.impl.APIConstants; | ||
|
|
||
| import java.util.Map; | ||
| import java.util.*; |
There was a problem hiding this comment.
Better not to use wild card imports. Importing specific class improves readability
chamilaadhi
reviewed
Nov 15, 2023
| Map<String, String> key = entry.getKey(); | ||
| //if resource path is empty, proceeding with API level logs | ||
| if (selectedApi.getContext().equals(key.get("context"))) { | ||
| if (key.get("resourcePath") == null && key.get("resourceMethod") == null) { |
There was a problem hiding this comment.
use constants previously defined
chamilaadhi
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Why a dependency is added here?
|
Closing as the changes are added from PR [1]. [1] #12288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wso2/api-manager#1564
Test Case for this PR: wso2/product-apim#13260