Remove Hazelcast address from node heartbeat table #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5anka
force-pushed
the
remove_hazelcast
branch
from
bb4b530
to
6299c5b
Compare
Asitha
reviewed
Aug 23, 2017
| @@ -144,24 +135,11 @@ public void start(BundleContext context) throws AndesException { | |||
| AndesContext.getInstance().setClusteringEnabled(false); | |||
There was a problem hiding this comment.
We still have a distinction between standalone and clustering?
There was a problem hiding this comment.
Yes. I did not remove it. Standalone mean non cluster aware.
Asitha
approved these changes
Aug 23, 2017
bsenduran
reviewed
Aug 23, 2017
| @@ -9,3 +9,6 @@ target | |||
| *.ipr | |||
| *.iws | |||
| *.db | |||
|
|
|||
| # Maven generated resource files | |||
| features/org.wso2.carbon.business.messaging.core.feature/src/main/resources | |||
There was a problem hiding this comment.
IMO, it is better to generate the source in the target directory
There was a problem hiding this comment.
Thanks @bsenduran. Will do in the later iteration. Tracked with #576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.