Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capability to associate v2 roles with applications #5001

Merged
merged 22 commits into from
Oct 23, 2023
Merged

Add capability to associate v2 roles with applications #5001

merged 22 commits into from
Oct 23, 2023

Conversation

AnuradhaSK
Copy link
Contributor

@AnuradhaSK AnuradhaSK commented Oct 15, 2023 •
edited
Loading

Proposed changes in this pull request

$Subject

When should this PR be merged

After merging

This was referenced Oct 15, 2023
Merged
Closed
Merged
Merged
@AnuradhaSK AnuradhaSK marked this pull request as ready for review October 19, 2023 11:47
@AnuradhaSK AnuradhaSK force-pushed the role-association-for-app branch 3 times, most recently from df4dedf to 5322f42 Compare October 22, 2023 08:04
AnuradhaSK
AnuradhaSK commented Oct 22, 2023
View reviewed changes
...main/java/org/wso2/carbon/identity/application/common/util/IdentityApplicationConstants.java
@@ -1,7 +1,7 @@
/*
* Copyright (c) 2014, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.
* Copyright (c) 2014-2023, WSO2 LLC. (http://www.wso2.com).
Copy link
Contributor Author

@AnuradhaSK AnuradhaSK Oct 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file already changed with Rolev2 mgt PR.
Change is not included in this PR because of conflict resolving, but license update is kept to reflect the reason change

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6602665865

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6602665865
Status: failure

thanujalk
thanujalk previously approved these changes Oct 22, 2023
View reviewed changes
shashimalcse
shashimalcse previously approved these changes Oct 22, 2023
View reviewed changes
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6603839317

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6603839317
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6603934276

shashimalcse
shashimalcse previously approved these changes Oct 22, 2023
View reviewed changes
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6603934276
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6604259088

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6604259088
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6604795675

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6604795675
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6605045434

shashimalcse
shashimalcse previously approved these changes Oct 22, 2023
View reviewed changes
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6605045434
Status: cancelled

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6607803303
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6609551291

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6609551291
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 23, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6609551291

@AnuradhaSK AnuradhaSK merged commit 520d8c1 into wso2:master Oct 23, 2023
2 checks passed
@AnuradhaSK AnuradhaSK deleted the role-association-for-app branch October 23, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@shashimalcse shashimalcse shashimalcse approved these changes

@thanujalk thanujalk thanujalk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnuradhaSK @jenkins-is-staging @thanujalk @shashimalcse