Invoke user core APIs when resolving groups #5462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somindatommy
force-pushed
the
improve_group_dao
branch
2 times, most recently
from
2293b0b
to
39b12ed
Compare
shashimalcse
reviewed
Feb 1, 2024
...le.v2.mgt.core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/GroupDAOImpl.java
Outdated
Show resolved
Hide resolved
shashimalcse
reviewed
Feb 1, 2024
...le.v2.mgt.core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/GroupDAOImpl.java
Outdated
Show resolved
Hide resolved
shashimalcse
reviewed
Feb 1, 2024
...le.v2.mgt.core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/GroupDAOImpl.java
Outdated
Show resolved
Hide resolved
somindatommy
force-pushed
the
improve_group_dao
branch
from
9e245dd
to
b392739
Compare
shashimalcse
reviewed
Feb 2, 2024
...ity.role.mgt.core/src/main/java/org/wso2/carbon/identity/role/mgt/core/dao/GroupDAOImpl.java
Outdated
Show resolved
Hide resolved
somindatommy
force-pushed
the
improve_group_dao
branch
from
8f24563
to
62c4665
Compare
somindatommy
force-pushed
the
improve_group_dao
branch
from
62c4665
to
a91d06d
Compare
shashimalcse
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Invoking the user core APIs to resolve the group names and attributes. The existing implementation uses SCIM tables. But the new improvements to user core do not store group attributes in the scim tables. Therefore, for group related operations user core APIs need to be invoked.
This is related to following issues
When should this PR be merged
After merging the following PRs.
Follow up actions