-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config to get the totalResults by user count #5533
Conversation
features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/identity.xml.j2
Outdated
Show resolved
Hide resolved
features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/identity.xml
Outdated
Show resolved
Hide resolved
Default value : false | ||
Supported versions : IS 7.0.0 onwards | ||
--> | ||
<!--<EnableGroupBasedUserFilteringImprovements>false</EnableGroupBasedUserFilteringImprovements>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for commenting this out?
features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/identity.xml
Outdated
Show resolved
Hide resolved
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8628566269
Proposed changes in this pull request
Resolve the issue: wso2/product-is#12813
When the SCIM API is invoked with a filter, the current behavior involves returning a predefined value for the totalResults parameter based on the MaxUserNameListLength, rather than reflecting the actual results that match the filter criteria. This fix addresses the issue by accurately determining the user count that corresponds to the given filter. To enable this fix, the following config should be added
Related PRs: wso2-extensions/identity-inbound-provisioning-scim2#533, wso2/carbon-kernel#3906
When should this PR be merged
[Please describe any preconditions that need to be addressed before we
can merge this pull request.]
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation