Add restrictToPublished Param when Branding Resolver is Called
#5820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…published branding at runtime.
AnuradhaSK
previously approved these changes
Jul 29, 2024
AnuradhaSK
reviewed
Jul 29, 2024
| @@ -87,6 +89,8 @@ public JSONObject getPreference(String tenant, String type, String name, String | |||
| if (StringUtils.isNotBlank(locale)) { | |||
| uriBuilder.addParameter(RESOURCE_LOCALE_URL_SEARCH_PARAM, locale); | |||
| } | |||
|
|
|||
| uriBuilder.addParameter(RESTRICT_TO_PUBLISHED_URL_SEARCH_PARAM, TRUE); | |||
There was a problem hiding this comment.
Also don't we need to consider this param for getCustomTextPreference method?
There was a problem hiding this comment.
Fix for text customizations is tracked by wso2/product-is#20858
AnuradhaSK
approved these changes
Aug 9, 2024
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10347302972
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
restrictToPublishedparam astruein order to obtain the nearest published branding preferences at runtime.When should this PR be merged
Related Issues