Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SCIM2 Group based User Filtering Improvements by Default #5830

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Enable SCIM2 Group based User Filtering Improvements by Default #5830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbe1ee5
Enabled scim2 group based user filtering improvements.
dhaura Aug 1, 2024
550441d
Update comments in identity.xml for EnableGroupBasedUserFilteringImpr…
dhaura Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/identity.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,9 +1011,9 @@
It determines the totalResults based on the total user count corresponding to the given group-based filter.
Additionally, when invoking the user endpoint with a groups filter by passing a role (hybrid or system roles),
it returns an empty list when role group separation is enabled, instead of returning users linked to the passed role.
Default value : false
Default value : true
-->
<!--<EnableGroupBasedUserFilteringImprovements>false</EnableGroupBasedUserFilteringImprovements>-->
<!--<EnableGroupBasedUserFilteringImprovements>true</EnableGroupBasedUserFilteringImprovements>-->

</SCIM2>

Expand Down
2 changes: 1 addition & 1 deletion ...ures/identity-core/org.wso2.carbon.identity.core.server.feature/resources/identity.xml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1478,7 +1478,7 @@
It determines the totalResults based on the total user count corresponding to the given group-based filter.
Additionally, when invoking the user endpoint with a groups filter by passing a role (hybrid or system roles),
it returns an empty list when role group separation is enabled, instead of returning users linked to the passed role.
Default value : false
Default value : true
-->
<EnableGroupBasedUserFilteringImprovements>{{scim2.enable_group_based_user_filter_improvements}}</EnableGroupBasedUserFilteringImprovements>

Expand Down
2 changes: 1 addition & 1 deletion ...y.core.server.feature/resources/org.wso2.carbon.identity.core.server.feature.default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@
"scim2.endpoints.groups_endpoint": "$ref{server.base_path}/scim2/Groups",
"scim2.enable_complex_multivalued_attribute_support": false,
"scim2.enable_filtering_enhancements": false,
"scim2.enable_group_based_user_filter_improvements": false,
"scim2.enable_group_based_user_filter_improvements": true,
"scim2.notify_userstore_status": false,
"scim2.filter_users_and_groups_from_primary_domain": false,
"scim2.mandate_domain_for_uesrnames_and_group_names_in_response": false,
Expand Down
Loading