Add authentication Types for authenticators. #5901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thisara-Welmilla
force-pushed
the
add-authentication-type
branch
2 times, most recently
from
6121b29
to
6f22057
Compare
Thisara-Welmilla
force-pushed
the
add-authentication-type
branch
from
6f22057
to
da06b15
Compare
malithie
reviewed
Sep 2, 2024
| AuthenticatorType authenticatorType = authenticator.getAuthenticatorType(); | ||
| if ((AuthenticatorType.SYSTEM.equals(authenticatorType) && authenticator instanceof | ||
| FederatedApplicationAuthenticator) || (AuthenticatorType.CUSTOM.equals(authenticatorType) | ||
| && stepConfig.getAuthenticatedUser().isFederatedUser())) { |
There was a problem hiding this comment.
does step config has the respective user authenticated by the respective authenticator ?
|
Let's cover the test cases along with the PR or let's merge to a feature branch and merge as tests are covered only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task issue:
With above feature, we will introduce an authentication adapter that extends the
AbstractApplicationAuthenticatorand implements theFederatedApplicationAuthenticatorclass. This adapter will support to authenticated both LOCAL and FEDERATED users and user type will be defined at runtime. The authentication flow will need to accommodate both types. To achieve this, the following improvements will introduced with this PR:getAuthenticatorType()to theApplicationAuthenticatorinterface, with SYSTEM as the default return value.getAuthenticatorType()method to return their CUSTOM type.instanceof FederatedApplicationAuthenticatorcheck, which ideally should be based on the authenticated user (isFedUser()) of the corresponding step. Those will be updated.