Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout server configurations to action execution #5935

Merged
merged 10 commits into from
Sep 19, 2024

Conversation

osandamaleesha
Copy link
Contributor

@osandamaleesha osandamaleesha commented Sep 12, 2024

Proposed changes in this pull request

This PR adds http client related server configurations to action execution and updates unit tests in ActionExecutorConfigTest, APIClientTest and ActionExecutorServiceImpl classes. wso2/product-is#21119

When should this PR be merged

Soon

Follow up actions

N/A

@malithie
Copy link
Member

Let's add a configuration the the http connection pool as well
PoolingHttpClientConnectionManager connectionManager = new PoolingHttpClientConnectionManager(); connectionManager.setMaxTotal(20);

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 21.11%. Comparing base (6b94bf9) to head (a8fffd8).
Report is 77 commits behind head on master.

Files with missing lines Patch % Lines
...ty/action/execution/util/ActionExecutorConfig.java 89.65% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5935      +/-   ##
============================================
+ Coverage     21.07%   21.11%   +0.04%     
- Complexity     5626     5642      +16     
============================================
  Files          1561     1561              
  Lines         99202    99234      +32     
  Branches      15189    15185       -4     
============================================
+ Hits          20904    20953      +49     
+ Misses        75277    75257      -20     
- Partials       3021     3024       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@malithie malithie merged commit c2afbe4 into wso2:master Sep 19, 2024
4 checks passed
@osandamaleesha osandamaleesha deleted the add/ServerConfigurations branch September 20, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants