-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dual scopes from Notification template api access controls #6058
Remove dual scopes from Notification template api access controls #6058
Conversation
PR builder started |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6058 +/- ##
============================================
+ Coverage 40.25% 40.38% +0.13%
+ Complexity 14340 14321 -19
============================================
Files 1746 1746
Lines 118269 117541 -728
Branches 19225 19093 -132
============================================
- Hits 47604 47469 -135
+ Misses 63346 62783 -563
+ Partials 7319 7289 -30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… refactor to placement.
457f574
to
4e1fdd3
Compare
PR builder completed |
PR builder started |
Quality Gate passedIssues Measures |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11501632929
Proposed changes in this pull request
The added configuration of two scopes for the same endpoint is wrong and is not currently supported. This PR fixes that by removing the old scope from the previous email template management API and keeps the new scope configuration.
This also places the notification template management API(NTM) access control definitions above email template management API(ETM) access control definitions since the ETM API access control definition regex pattern could match the NTM API access control definitions, resulting in the NTM requiring the ETM scopes to function.
Related Issue
Related PR