Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add In-Memory Claim Management #6136

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

amanda-ariyaratne
Copy link
Contributor

Reverts #6127

Copy link

sonarcloud bot commented Nov 19, 2024

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 84.69602% with 73 lines in your changes missing coverage. Please review.

Project coverage is 41.03%. Comparing base (0fc102d) to head (eab9155).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...laim/metadata/mgt/UnifiedClaimMetadataManager.java 88.64% 12 Missing and 9 partials ⚠️
.../claim/metadata/mgt/DefaultClaimMetadataStore.java 0.00% 17 Missing ⚠️
...tadata/mgt/ClaimMetadataManagementServiceImpl.java 74.60% 12 Missing and 4 partials ⚠️
...ty/claim/metadata/mgt/util/ClaimMetadataUtils.java 75.00% 6 Missing and 4 partials ⚠️
...identity/claim/metadata/mgt/dao/LocalClaimDAO.java 80.95% 3 Missing and 1 partial ⚠️
...etadata/mgt/SystemDefaultClaimMetadataManager.java 97.33% 1 Missing and 1 partial ⚠️
...rbon/identity/claim/metadata/mgt/dao/ClaimDAO.java 88.23% 2 Missing ⚠️
...laim/metadata/mgt/DBBasedClaimMetadataManager.java 98.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6136      +/-   ##
============================================
+ Coverage     40.75%   41.03%   +0.28%     
- Complexity    14633    14754     +121     
============================================
  Files          1772     1777       +5     
  Lines        119759   118558    -1201     
  Branches      19523    20005     +482     
============================================
- Hits          48808    48656     -152     
+ Misses        63595    62586    -1009     
+ Partials       7356     7316      -40     
Flag Coverage Δ
unit 25.61% <84.69%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@amanda-ariyaratne
Copy link
Contributor Author

Integration tests are expected to fail by this PR. They will be fixed with wso2/product-is#21601

@amanda-ariyaratne amanda-ariyaratne merged commit 671f33b into master Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants