Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localising tenant retrival from username and getting tenant from session while authorising the admin #3648

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Localising tenant retrival from username and getting tenant from session while authorising the admin #3648

merged 6 commits into from
Sep 14, 2023

Conversation

Thumimku
Copy link

@Thumimku Thumimku commented Aug 17, 2023 •
edited
Loading

With wso2/product-is#16357, we need to modify the carbon console login as $. With that change, if the user name is email type then the username should append the tenant domain.

This change on can enabled with a configuration from #3667

Mail: [Unification] Bring new tenant level Password/username validation feature to IS

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5996057667

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5996057667
Status: failure

@Thumimku
Copy link
Author

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/5996057667 Status: failure

This is because in [1] login with email would be changed, cause this produce a behavioural change,

[1]-https://github.com/wso2/product-is/blob/a4ffe1555b7d3cf18c32d86b5b05c56dd28bfd3b/modules/integration/tests-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/user/mgt/CARBON15051EmailLoginTestCase.java#L85

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6180585766

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6180853965

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6180585766
Status: cancelled

chamathns
chamathns previously approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@chamathns chamathns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6180853965
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6181744006

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6181744006
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6181972954

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6181972954
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Sep 14, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6181972954

@Thumimku Thumimku merged commit 02ae624 into wso2:4.9.x Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madurangasiriwardena madurangasiriwardena madurangasiriwardena left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@chamathns chamathns chamathns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thumimku @jenkins-is-staging @madurangasiriwardena @chamathns