Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve getUserCountByRole() Method #3951

Merged
merged 13 commits into from
Apr 5, 2024
Merged

Improve getUserCountByRole() Method #3951

merged 13 commits into from
Apr 5, 2024

Conversation

dhaura
Copy link

@dhaura dhaura commented Mar 22, 2024 •
edited
Loading

Purpose

  • The following improvements have been done to getUserCountByRole() method.
    • Rename the method to getUserCountByGroup()
    • Add recursive check to resolve user store.
    • Add new getUserListOfGroupWithID method to retrieve user list only for groups.
    • Add backward compatibility to retrieve user count when unique id feature is disabled.
    • Remove unused filter property.
    • Add unit tests.

Related Issues

Related PRs

@dhaura dhaura marked this pull request as draft March 22, 2024 11:34
@dhaura @asha15
Update core/org.wso2.carbon.user.core/src/main/java/org/wso2/carbon/u…
a895fc6 
…ser/core/common/AbstractUserStoreManager.java

Co-authored-by: Asha Sulaiman <165079T@uom.lk>
@dhaura dhaura marked this pull request as ready for review March 26, 2024 10:50
@CLAassistant
Copy link

CLAassistant commented Mar 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dhaura dhaura mentioned this pull request Mar 29, 2024
Merged
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8519952466

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8519952466
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Apr 2, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8519952466

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8548628261

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8548628261
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8549758450

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8549758450
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Apr 4, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8549758450

@sumedhe sumedhe merged commit 27c14fd into wso2:4.10.x Apr 5, 2024
1 check passed
@dhaura dhaura mentioned this pull request Jun 3, 2024
Merged
This was referenced Aug 1, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnuradhaSK AnuradhaSK AnuradhaSK approved these changes

@asha15 asha15 asha15 left review comments

@bhagyasakalanka bhagyasakalanka bhagyasakalanka left review comments

@ashensw ashensw ashensw approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dhaura @CLAassistant @jenkins-is-staging @ashensw @AnuradhaSK @asha15 @bhagyasakalanka @sumedhe