Merge pull request #386 from Yasasr1/add-forbidden

Handle forbidden responses when updating roles with a patch request
wso2 · Jul 10, 2023 · e7545fe · e7545fe
2 parents 008515f + 5aa8cf6
commit e7545fe
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/modules/charon-core/src/main/java/org/wso2/charon3/core/extensions/RoleManager.java b/modules/charon-core/src/main/java/org/wso2/charon3/core/extensions/RoleManager.java
@@ -21,6 +21,7 @@
 import org.wso2.charon3.core.exceptions.BadRequestException;
 import org.wso2.charon3.core.exceptions.CharonException;
 import org.wso2.charon3.core.exceptions.ConflictException;
+import org.wso2.charon3.core.exceptions.ForbiddenException;
 import org.wso2.charon3.core.exceptions.NotFoundException;
 import org.wso2.charon3.core.exceptions.NotImplementedException;
 import org.wso2.charon3.core.objects.Role;
@@ -129,7 +130,8 @@ RolesGetResponse listRolesWithPost(SearchRequest searchRequest)
      * @throws NotImplementedException Functionality no implemented exception.
      */
     default Role patchRole(String roleId, Map<String, List<PatchOperation>> patchOperations)
-            throws NotImplementedException, BadRequestException, CharonException, ConflictException, NotFoundException {
+            throws NotImplementedException, BadRequestException, CharonException, ConflictException, NotFoundException,
+            ForbiddenException {
 
         throw new NotImplementedException("patchRole method is not implemented");
     }

diff --git a/...aron-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/RoleResourceManager.java b/...aron-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/RoleResourceManager.java
@@ -32,6 +32,7 @@
 import org.wso2.charon3.core.exceptions.BadRequestException;
 import org.wso2.charon3.core.exceptions.CharonException;
 import org.wso2.charon3.core.exceptions.ConflictException;
+import org.wso2.charon3.core.exceptions.ForbiddenException;
 import org.wso2.charon3.core.exceptions.InternalErrorException;
 import org.wso2.charon3.core.exceptions.NotFoundException;
 import org.wso2.charon3.core.exceptions.NotImplementedException;
@@ -613,7 +614,7 @@ private SCIMResponse updateWithPatchOperations(String existingRoleId, List<Patch
             Role updatedRole = roleManager.patchRole(existingRoleId, patchOperations);
             return getScimResponse(encoder, updatedRole);
         } catch (NotFoundException | BadRequestException | NotImplementedException | ConflictException |
-                 CharonException | InternalErrorException e) {
+                 CharonException | InternalErrorException | ForbiddenException e) {
             return AbstractResourceManager.encodeSCIMException(e);
         }
     }