PCS-2420: decode incoming requests independent of case of attribute n… #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ames like userName
|
|
ionutned
reviewed
Oct 17, 2022
| String attributeSchemaName = attributeSchema.getName().toLowerCase(); | ||
| for (Iterator it = decodedJsonObj.keys(); it.hasNext(); ) { | ||
| String key = (String) it.next(); | ||
| if (key.toLowerCase().equals(attributeSchemaName)) { |
There was a problem hiding this comment.
we could use key.equalsIgnoreCase()
There was a problem hiding this comment.
Thanks for the hint. Changed it accordingly: 58677aa
| @@ -1247,7 +1247,7 @@ public void testGetUserName(Object objectUser, String scimObjectString) | |||
| public Object[][] dataToTestGetUsernameErrorInGettingTheUsernameFromTheAnonymousRequest() { | |||
|
|
|||
| String scimObjectString = "{\n" + | |||
| "UserName: John,\n" + | |||
| "UsrName: John,\n" + | |||
There was a problem hiding this comment.
This small change might be hard to notice by people looking at this test.
|
@AnuradhaSK @VivekVinushanth what do I need to do to get a review from one of the owners? |
AnuradhaSK
reviewed
Mar 20, 2023
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.*; |
There was a problem hiding this comment.
Avoid * imports.
Import just only the required classes
There was a problem hiding this comment.
Thanks. I changed that: f276f89
There was a problem hiding this comment.
@AnuradhaSK am I ready to merge?
There was a problem hiding this comment.
@AnuradhaSK am I still missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Goals
Approach
Release note
Automation tests
-> adjusted
testGetUserNameErrorInGettingTheUsernameFromTheAnonymousRequestto only fail for wrong spelling of the attribute name and not for different case use.