Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scim group patch call when only value attribute is present for members. #391

Closed

Conversation

ZiyamSanthosh
Copy link

Currently, we expect both display and value attributes to be present to update a group with a user during an add operation. With this implementation, the display attribute is made optional and a group can be updated with a user by providing the userId as the value for the value attribute.

Related issue:

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6098982753

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6098982753
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6098982753

@nilasini
Copy link
Contributor

nilasini commented Sep 9, 2023

Since the behavior is getting differ in different each product version can you arrange a review session?

@ZiyamSanthosh
Copy link
Author

Since the behaviour has changed in the latest version of the product, this change is not required. Hence, closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants